WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 3/4] rombios interface for HVM S3

To: Juergen Keil <jk@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 3/4] rombios interface for HVM S3
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 02 Jun 2008 15:14:10 +0100
Delivery-date: Mon, 02 Jun 2008 07:14:51 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080602134538.A75DB4BD24@xxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcjEuu0LK5MxIjCuEd2v7AAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH 3/4] rombios interface for HVM S3
User-agent: Microsoft-Entourage/11.4.0.080122
On 2/6/08 14:45, "Juergen Keil" <jk@xxxxxxxx> wrote:

> For unknown reasons, HVM S3 resume hangs in the bios when trying to load
> the x_firmware_waking_vector from absolute address 0xEA01C (it hangs for
> access to address 0x10000, but doesn't hang for 0xfffe).

It works on Intel because there we emulate the rombios, and our emulator
does not bother with segment limit checks in real mode. This is actually
more lenient than real hardware, hence an AMD CPU (which is directly
executing the rombios code) will fault on the access because it is at a
segment offset greater than 64kB.

Your patch is good. Please re-submit with a fixed changeset comment and a
signed-off-by line. I'll then check it in.

 Thanks,
 Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>