Re: [Xen-devel] [PATCH 10 of 12] xen: implement save/restore

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

On Mon, Jun 02, 2008 at 11:03:36AM +0100, Jeremy Fitzhardinge wrote:
> Isaku Yamahata wrote:
> >What is the purpose of load_cr3() here?
> >I'd like to make this load_cr3() more arch generic for ia64 support.
> >(or eliminate it if possible)
> >  
> 
> I think it's an unnecessary left-over from when I was trying to get that 
> stuff to work.  I can't think of a good reason not to just remove it if 
> it causes you problems.

Here is the patch. I did only compile test.


> BTW, I tried to split the suspend/resume stuff into common and things 
> which were definitely x86-specific with you in mind.  How close did I get?

Almost complete. Your effort made my task easier.
I haven't yet succeeded to save/restore, though.

Is CONFIG_PM_SLEEP necessary?
Since ia64 doesn't define ARCH_HIBERNATION_POSSIBLE nor
ARCH_SUSPEND_POSSIBLE.
Although I can define them in ia64/xen/Kconfig, I'd like to leave
them untouched if possible.

>From 93906ae3785206cdd1e25e27b3797914f24f55aa Mon Sep 17 00:00:00 2001
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Mon, 2 Jun 2008 19:36:20 +0900
Subject: [PATCH] xen: clean up of manage.c

remove load_cr3() from manage.c. It is unncessary and x86 dependent.

Signed-off-by: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
---
 drivers/xen/manage.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
index 675c3dd..28bb618 100644
--- a/drivers/xen/manage.c
+++ b/drivers/xen/manage.c
@@ -38,8 +38,6 @@ static int xen_suspend(void *data)
 
        BUG_ON(!irqs_disabled());
 
-       load_cr3(swapper_pg_dir);
-
        err = device_power_down(PMSG_SUSPEND);
        if (err) {
                printk(KERN_ERR "xen_suspend: device_power_down failed: %d\n",
-- 
1.5.3




-- 
yamahata

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel