WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel]about the super page support with EPT

To: "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>
Subject: RE: [Xen-devel]about the super page support with EPT
From: "Xin, Xiaohui" <xiaohui.xin@xxxxxxxxx>
Date: Tue, 20 May 2008 17:03:01 +0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 20 May 2008 02:04:23 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C4584CE5.20D86%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <9A1462408D6D394C8A7A812E98F00A4D02EF2A57@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C4584CE5.20D86%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Aci6U1T79Ml0ZnacQziUOSNI7fKrtQAAbtqzAADEEHA=
Thread-topic: [Xen-devel]about the super page support with EPT

Ok, that may make sense, and I will make the patch for it.

 

Thanks

Xiaohui

 


From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx]
Sent: Tuesday, May 20, 2008 4:40 PM
To: Xin, Xiaohui
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel]about the super page support with EPT

 

On 20/5/08 09:27, "Xin, Xiaohui" <xiaohui.xin@xxxxxxxxx> wrote:

The recent super page support patch checked in met some problem when EPT was enabled. The patch lost some code during checking in.
>From our experience, in EPT enabled situation, we has to split the last 2M of the guest memory to 4k pages instead of 2M contiguous, the reason is that, in tools side, 5 special pages are located in guest high end memory, and the guard page will be decreased then. It will result to set the p2m entry with order 0 to be invalid, in normal logic, this will result to set the whole 2m p2m entry with order 9 to be invalid, then all the other 4k pages in the last 2M cannot be accessed. The end result is that we will get “Bad address” error when we create guest with EPT.
 

The patch may make sense since it avoids needlessly shattering a physical 2MB extent, but actually your underlying EPT logic should be able to handle this shattering anyway. It is allowable to allocate superpages and free 4kB pages and your EPT mis-handling of this case is a bug. I think the underlying Xen fix should be implemented, tested and applied first, before considering this tools patch.

 -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>