Re: [Xen-devel] VMX status report. Xen: #17630 & Xen0: #540 -- blocked

[Kevin Wolf <kwolf@xxxxxxx>]

Xu, Dongxiao schrieb:
> I just tried your patch, and seems that it doesn't work.
> Actually, find_protocol() could not find out the qcow protocol, and for qcow 
> image, that function will always return NULL after C/S 17606. I think this is 
> the root cause why qcow image could not be booted. 

find_protocol isn't even responsible for finding out that it's qcow.
There is a difference between image format and protocol (IIRC, the
latter is used in qemu for things like vvfat which maps a host directory
to a virtual FAT floppy/harddisk). I suspect the problem arises from the
bdrv_file_open call in find_image_format which won't correctly get
&bdrv_raw but NULL as driver.

And you're right, the patch can't work. I missed that in bdrv_open2 for
BDRV_O_FILE drv is ignored and always overwritten.

Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel