WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] Enable Px/Cx related CPUID/MSR bits for dom0

To: "Wei, Gang" <gang.wei@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] Enable Px/Cx related CPUID/MSR bits for dom0
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 05 May 2008 17:05:14 +0100
Delivery-date: Mon, 05 May 2008 09:05:23 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <094BCE01AFBE9646AF220B0B3F367AAB030760CF@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Aciucp7xXvPGFQVHQc62vzQNeMPItQAH5bLaAAyz9wAAATH80Q==
Thread-topic: [PATCH] Enable Px/Cx related CPUID/MSR bits for dom0
User-agent: Microsoft-Entourage/11.4.0.080122
I'll remove them and you can add them back in with a comment if they turn
out to be required.

 -- Keir

On 5/5/08 16:48, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:

> On Monday, May 05, 2008 5:27 PM, Keir Fraser wrote:
>> Applied your patches, but why would you expose MWAIT as a usable
> feature?
> 
> I can't exactly tell why. What I am sure is that X86_FEATURE_EST should
> be exposed, otherwise ACPI _CST method invoking in dom0 will always
> failed. MWAIT feature & MSR_IA32_MISC_ENABLE_MONITOR_ENABLE bit are
> exposed just in case of possible needs. If I could make sure MWAIT
> feature & MONITOR_ENABLE are not needed, I will send patch to remove
> them.
> 
>> Maybe worth a comment explaining that, as otherwise it's not unlikely
> to
>> be cleaned up as a 'mistake' sometime in the future.
> 
> Ok, I will add comment after I can explain clearly.
> 
> Jimmy



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel