WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] linux/balloon: don't allow ballooningdowna domai

To: "Alan Cox" <alan@xxxxxxxxxxxxxxxxxxx>, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] linux/balloon: don't allow ballooningdowna domain below a reasonable limit
From: "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx>
Date: Thu, 1 May 2008 17:27:53 -0600
Cc: Ky Srinivasan <KSrinivasan@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, KurtGarloff <garloff@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxxxx>
Delivery-date: Thu, 01 May 2008 16:29:44 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080502000310.361b9c99@core>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Oracle Corporation
Reply-to: "dan.magenheimer@xxxxxxxxxx" <dan.magenheimer@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acir4vjMmun6nBQMSpW/phdu9vBZbA==
> > It might be the case though that, in practice, vm_committed_space is a
> > reasonable predictor for working set for some common types of workload. Many
> > applications probably keep their heaps fairly warm and hence in main memory.

Yes, and it also seems to be an "advance" predictor so that
the balloon driver has an opportunity to release pages to
a soon-to-be-memory-hungry domain before it really needs them
(or in case it might).

> I am dubious. What vm_committed_space does allow you to do 
> however if you
> watch it in Xen is to actually ensure you never balloon out a virtual
> machine to the point you make it start killing stuff off.

Oddly, this is the opposite of what I observed.  When I replaced
Jan's minimum_target calculation in the balloon driver with just
vm_committed_space (accidentally), I got lots of OOM's when I
was shutting down.  So vm_committed_space CAN shrink too far
sometime and needs to be lower-bounded by some other calculated
minimum.

> There are better ways to measure memory pressure - sizes of the various
> active and inactive lists etc. OLPC has code for this and a proposed
> memory pressure notifier feature that they use to allow user space apps
> to cleanup.

Definitely agreed that vm_committed_space is just intended to be
a first order approximation.  It also has the advantage of having
been around awhile so that the balloon driver will work with many
distros rather than require a TBD memory pressure indicator.

Alan, do you have a pointer to the proposed OLPC code?

Keir, I'm working on some xenbus support and will submit an
updated patch, probably early next week.  I also have a horrible
hack to work in a module, but I suspect that will get jettisoned. ;-)

Thanks,
Dan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>