xen-devel

[Top] [All Lists]

[Xen-devel] [XENSTORED] Fix xenstored abort when connection dropped.

from [Ian Campbell]

[Permanent Link][Original]

To:	xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] [XENSTORED] Fix xenstored abort when connection dropped.
From:	Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date:	Wed, 30 Apr 2008 17:32:53 +0100
Cc:	Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date:	Thu, 01 May 2008 08:03:19 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization:	Citrix Systems, Inc.
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

[XENSTORED] Fix xenstored abort when connection dropped.

If a connection is dropped with pending input and output data then the
connection will be dereferenced by both handle_input and handle_output
resulting in a double free when the main loop dereferences the
connection.

Fix this issue by taking/releasing a reference over the calls to
handle_input and handle_output separately and checking the result of
talloc_free to see if the connection went away.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

The attached t.c will show you the crash in a few seconds at most
        # gcc ~/t.c
        # while ./a.out  ; do : ; done
        main: Connection refused
        Aborted

Ian.

xenstore-abort.patch
Description: Text Data

t.c
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [XENSTORED] Fix xenstored abort when connection dropped., Ian Campbell <=

Previous by Date:	Re: [Xen-devel] [PATCH] linux/balloon: don't allow ballooningdowna domain below a reasonable limit, Keir Fraser
Next by Date:	RE: [Xen-devel] [PATCH 1/9] Add cpu idle pwr mgmt to xen, Wei, Gang
Previous by Thread:	[Xen-devel] [PATCH] hvm's cpuid config fix, Jean Guyader
Next by Thread:	Re: [Xen-devel] Vanilla Linux and has_foreign_mapping, Michael Abd-El-Malek
Indexes:	[Date] [Thread] [Top] [All Lists]