WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Make ACPI DMAR parsing more robust

To: Espen Skoglund <espen.skoglund@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Make ACPI DMAR parsing more robust
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 03 Apr 2008 11:21:48 +0100
Delivery-date: Thu, 03 Apr 2008 03:23:07 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <18419.47951.625663.623377@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AciVdIYuxPZn/gFnEd2x0gAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] Make ACPI DMAR parsing more robust
User-agent: Microsoft-Entourage/11.4.0.080122
Regarding the table length sanity check -- depth is set to the number of
acp_pci_path structures in the table. But then we only follow the path to
depth-1. Is that correct?

Also I changed the test to '--depth >= 0' which is equivalent and a bit
easier to read imo.

 -- Keir


On 2/4/08 17:58, "Espen Skoglund" <espen.skoglund@xxxxxxxxxxxxx> wrote:

> Parsing ACPI related VT-d tables may cause infinite loop due to u8
> value wraparound.  Also add sanity check on table length entry.
> 
> eSk
> 
> 
> Signed-off-by: Espen Skoglund <espen.skoglund@xxxxxxxxxxxxx>
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>