WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [RFC][PATCH] Use ioemu block drivers through blktap

To: Kevin Wolf <kwolf@xxxxxxx>
Subject: Re: [Xen-devel] [RFC][PATCH] Use ioemu block drivers through blktap
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Mon, 31 Mar 2008 10:36:59 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 31 Mar 2008 03:09:33 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <47F0AA6E.2050909@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <47D569F6.1010209@xxxxxxx> <47D91D3D.1000005@xxxxxxx> <18413.3411.635161.295233@xxxxxxxxxxxxxxxxxxxxxxxx> <47F0AA6E.2050909@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Kevin Wolf writes ("Re: [Xen-devel] [RFC][PATCH] Use ioemu block drivers 
through blktap"):
> I needed a shutdown handler to properly close the blktap connection and
> delete the named pipes associated with the qemu-dm instance. When a
> domain is destroyed, qemu-dm receives a SIGHUP. However, with the
> default SIGHUP handler no atexit functions are called, so I had to add
> this handler which performs a clean exit.

Sadly in that case using a signal hanlder is no good, because qemu-dm
might die for some other reason than SIGHUP, skipping the cleanup.
(For example, it might have a bug and segfault, or the kernel's OOM
killer might send it a SIGKILL, or ...)

If this cleanup is really necessary, then that will cause problems for
future runs.  If not then the cleanup isn't really necessary :-).
Leftover named pipes, for example, aren't really a big problem and can
just be garbage collected at some point (provided their names are
sufficiently unique).

I haven't eyeballed all of the new qemu blktap arrangements in detail.
What processes are there and why can't the process at the other end of
the pipe do the cleanup ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel