WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH] Re: [Xen-staging] [xen-unstable] Explicitly

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] Re: [Xen-staging] [xen-unstable] Explicitly tag every anonymous aggregate in the public headers.
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Fri, 28 Mar 2008 16:55:53 -0600
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 28 Mar 2008 15:56:20 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C41323A9.15866%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: OSLO R&D
References: <C41323A9.15866%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2008-03-28 at 22:37 +0000, Keir Fraser wrote:
> On 28/3/08 21:04, "Alex Williamson" <alex.williamson@xxxxxx> wrote:
> 
> > @@ -609,7 +609,7 @@ struct xen_ia64_opt_feature {
> > unsigned long cmd;  /* Which feature */
> > unsigned char on;  /* Switch feature on/off */
> > __anonymous_union {
> > -  __anonymous_struct {
> > +  struct {
> > /* The page protection bit mask of the pte.
> > * This will be or'ed with the pte. */
> > unsigned long pgprot;
> 
> I have no idea if it's the cause of this particular boot breakage, but I
> reckon that an anonymous union containing a single anonymous struct can be
> simplified. Or perhaps, if the union is there for stylistic reasons, a
> single extra field in the union would fix things?

   I toggled this one separately exactly for that reason, but it's not
the one.  I still haven't isolated a particular reason why it fails in a
test program, but I'll keep trying.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel