WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][TOOLS] libfsimage: portability fixes

On Thu, Mar 27, 2008 at 03:36:45PM +0000, Ian Jackson wrote:

> Christoph Egger writes ("Re: [Xen-devel] [PATCH][TOOLS] libfsimage: 
> portability fixes"):
> > Everytime when I submitted a patch where I changed /bin/bash to /bin/sh
> > John Levon came up with a "Build is broken on Solaris" message.
> > The fix was always the same: Use $(SHELL) as this is explicitely set for
> > Solaris.
> 
> People whose /bin/sh is that badly broken deserve to lose IMO - that

Putting it mildly, I don't think that disabling an important platform
because you have a bee in your bonnet about $(SHELL) is a sensible
implementation choice.

john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel