 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] x86: fix variable_test_bit() asm constraints
| To: | Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] x86: fix variable_test_bit() asm constraints |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Fri, 14 Mar 2008 12:06:40 +0000 |
| Delivery-date: | Fri, 14 Mar 2008 05:07:50 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <C4001818.15017%keir.fraser@xxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AciFyj1lfDqkJfG9EdyPnAAWy6hiGQAAZ7bW |
| Thread-topic: | [Xen-devel] [PATCH] x86: fix variable_test_bit() asm constraints |
| User-agent: | Microsoft-Entourage/11.3.6.070618 |
On 14/3/08 11:55, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:
>> Further, using 'void *' for the 'addr' parameter appears dangerous,
>> since bt{,c,r,s} access the full 32 bits (if 'unsigned long' was used
>> properly here, 64 bits for x86-64) pointed at, so invalid uses like
>> referencing a 'char' array cannot currently be caught.
>
> Sure, but those invalid uses do exist, in x86-specific Xen code we inherited
> from Linux (perhaps older versions of Linux though). I don't want a huge patch
> that casts a large number of callers!
I see what you mean though: what if one of these bogus users' fields is
adjacent to a legitimate byte-sized atomic variable (e.g., a bool_t)?
Perhaps we do need to fix this, and properly without casts.
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| Previous by Date: | Re: [Xen-devel] [PATCH] x86: fix variable_test_bit() asm constraints, Keir Fraser |
|---|---|
| Next by Date: | [Xen-devel] [PATCH] Add periodic fflush to xentop batch mode., Yusuke KANEKI |
| Previous by Thread: | Re: [Xen-devel] [PATCH] x86: fix variable_test_bit() asmconstraints, Jan Beulich |
| Next by Thread: | Re: [Xen-devel] [PATCH] x86: fix variable_test_bit() asmconstraints, Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
