WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: (progress on hpet accuracy) and Re: [Xen-devel] [PATCH] Add a timer

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: (progress on hpet accuracy) and Re: [Xen-devel] [PATCH] Add a timer mode that disables pending missed ticks
From: Dave Winchell <dwinchell@xxxxxxxxxxxxxxx>
Date: Wed, 05 Mar 2008 12:42:56 -0500
Cc: "dan.magenheimer@xxxxxxxxxx" <dan.magenheimer@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Deepak Patel <deepak.patel@xxxxxxxxxx>, Dave Winchell <dwinchell@xxxxxxxxxxxxxxx>
Delivery-date: Tue, 11 Mar 2008 11:05:11 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C3F48705.1D8B8%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C3F48705.1D8B8%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929)
Keir Fraser wrote:

On 5/3/08 17:25, "Dave Winchell" <dwinchell@xxxxxxxxxxxxxxx> wrote:

In 2.6.9, it looks like cur_timer->mark_offset() call from
timer_interrupt in
32 bit arch/i386/kernel/time.c invokes, for hpet, mark_offset_hpet(),
which computes
missed ticks based on hpet counter. mark_offset_pit() does nothing.
mark_offset_tsc() does compute missed ticks.

In 64 bit 2.6.9, the timer_interrupt() in arch/x86_64/time.c does hpet
reads directly HPET_T0_CMP, HPET_COUNTER to calculate missed ticks.

So from the code perspective, it looks like missed ticks are computed
for 32
and 64 bit Linux using hpet clocksource.

Ah. I looked at 2.6.18 which seems to have neither the mark_offset nor the
GENERIC_TIME approach in its arch/i386 time code. But yeah, it does look
like in general Linux 2.6 is robust to missed ticks when using hpet. That's
good.

Do you see and simply ignore warning messages from 64-bit Linux when using
hpet (or otherwise not doing missed-tick handling in Xen), by the way? I
know 64-bit Linux is keen to warn about missed ticks, although it does look
like at least the warning is one shot.
I see the one shot messages on 64 bit and no complaints at all on 4u432 Linux.
And I have been ignoring them.

-- Keir




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel