WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH]: Add "Warning" to the time went backwards messages

To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH]: Add "Warning" to the time went backwards messages
From: Chris Lalancette <clalance@xxxxxxxxxx>
Date: Mon, 10 Mar 2008 10:44:07 -0400
Cc: Prarit Bhargava <prarit@xxxxxxxxxx>
Delivery-date: Mon, 10 Mar 2008 07:44:43 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.12 (X11/20080226)
All,
    Attached is a patch from Prarit Bhargava, who is not subscribed to the list
(but CC'ed).  His description follows:

Add "Warning" to the "Time went backwards" message.

Most QA groups (if not all) grep for specific messages in the syslog such as
"Error", "Warning", "Oops".

Time went backwards is a key error which can result in system instability.

Signed-off-by: Prarit Bhargava <prarit@xxxxxxxxxx>
Add "Warning" to the "Time went backwards" message.

Most QA groups (if not all) grep for specific messages in the syslog such as
"Error", "Warning", "Oops".

Time went backwards is a key error which can result in system instability.

Signed-off-by: Prarit Bhargava <prarit@xxxxxxxxxx>

diff --git a/arch/i386/kernel/time-xen.c b/arch/i386/kernel/time-xen.c
index 532ad14..d4c8dfc 100644
--- a/arch/i386/kernel/time-xen.c
+++ b/arch/i386/kernel/time-xen.c
@@ -665,8 +665,8 @@ irqreturn_t timer_interrupt(int irq, void *dev_id, struct 
pt_regs *regs)
        if ((unlikely(delta < -(s64)permitted_clock_jitter) ||
             unlikely(delta_cpu < -(s64)permitted_clock_jitter))
            && printk_ratelimit()) {
-               printk("Timer ISR/%d: Time went backwards: "
-                      "delta=%lld delta_cpu=%lld shadow=%lld "
+               printk(KERN_WARNING "Warning Timer ISR/%d: Time went "
+                      "backwards: delta=%lld delta_cpu=%lld shadow=%lld "
                       "off=%lld processed=%lld cpu_processed=%lld\n",
                       cpu, delta, delta_cpu, shadow->system_timestamp,
                       (s64)get_nsec_offset(shadow),
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH]: Add "Warning" to the time went backwards messages, Chris Lalancette <=