 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH][retry 3][1/2] new vcpu op call to get physicalCP
| To: | "Mark Langsdorf" <mark.langsdorf@xxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH][retry 3][1/2] new vcpu op call to get physicalCPU information |
| From: | "Jan Beulich" <jbeulich@xxxxxxxxxx> |
| Date: | Wed, 05 Mar 2008 08:14:57 +0000 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Wed, 05 Mar 2008 00:14:55 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <200803041552.28425.mark.langsdorf@xxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <200803041552.28425.mark.langsdorf@xxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
>+ short temp = 0xff; Please use 0xffffffff here for forward compatibility. >+ >+ if ( !opt_dom0_vcpus_pin) >+ rc = -EINVAL; >+ rc = -EFAULT; This makes no sense; it's probably missing a 'break'. >+ >+ cpu_id.phys_id = x86_cpu_to_apicid[cpu_num]; >+ for (i = 0; i++; i < NR_CPUS) >+ if (x86_acpiid_to_apicid[i] == x86_cpu_to_apicid[cpu_num]) >+ temp = i; >+ cpu_id.phys_id |= temp << 8; Please shift by 32 here for forward compatibility. >-static unsigned int opt_dom0_vcpus_pin; >+unsigned int opt_dom0_vcpus_pin; >+EXPORT_SYMBOL(opt_dom0_vcpus_pin); EXPORT_SYMBOL()? Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [RFC] PVFB: Add refresh period to XenStore parameters?, Markus Armbruster |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH][retry 3][2/2] new vcpu op call to get physicalCPU information, Jan Beulich |
| Previous by Thread: | [Xen-devel] [PATCH][retry 3][1/2] new vcpu op call to get physical CPU information, Mark Langsdorf |
| Next by Thread: | Re: [Xen-devel] [PATCH][retry 3][1/2] new vcpu op call to get physicalCPU information, Ian Jackson |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
