On 4/3/08 08:59, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
> Finally, I'm worried about the way you handle dom0_vcpus_pinned:
> By its name, I would assume that if I (later, for whatever reason) use
> it elsewhere, I can be certain it means what it says. However, at
> present, the hypercall succeeding does not imply that VCPUs are
> indeed pinned. Further, under !is_initial_xen_domain() you shouldn't
> set it, nor should you have a reason to even attempt the hypercall.
I'm happy to clean up the dom0_vcpus_pinned side of this patch myself.
Anyway, if we make it a singleton-apicid vcpu_op, which fails on anything
other than a pinned dom0, I think we're good. I like the idea of simply
plucking the APICID from CPUID, but it does munge the code and I'm a bit
worried that we couldn't get the APICID until rather later than native Linux
(probably after the AP has booted but before it 'calls in').
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|