WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] linux: adjust Solarflare module_param() permissions

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] linux: adjust Solarflare module_param() permissions
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Thu, 21 Feb 2008 09:01:02 +0000
Delivery-date: Thu, 21 Feb 2008 01:01:18 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Using permissions with bit 1 set (i.e. 0666) is prohibited on module
parameters on 2.6.20+. Presumably it was never meant to permit writes
by everyone?

As usual, written and tested on 2.6.24.1 and made apply to the 2.6.18
tree without further testing.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

Index: head-2008-02-20/drivers/xen/sfc_netback/accel.c
===================================================================
--- head-2008-02-20.orig/drivers/xen/sfc_netback/accel.c        2008-02-20 
09:32:49.000000000 +0100
+++ head-2008-02-20/drivers/xen/sfc_netback/accel.c     2008-02-20 
14:48:01.000000000 +0100
@@ -72,7 +72,7 @@ static struct notifier_block netback_acc
 
 
 unsigned max_pages = NETBACK_ACCEL_DEFAULT_MAX_BUF_PAGES;
-module_param(max_pages, int, 0666);
+module_param(max_pages, int, 0644);
 MODULE_PARM_DESC(max_pages, 
                 "The number of buffer pages to enforce on each guest");
 
Index: head-2008-02-20/drivers/xen/sfc_netfront/accel_netfront.c
===================================================================
--- head-2008-02-20.orig/drivers/xen/sfc_netfront/accel_netfront.c      
2008-02-20 09:32:49.000000000 +0100
+++ head-2008-02-20/drivers/xen/sfc_netfront/accel_netfront.c   2008-02-20 
14:48:27.000000000 +0100
@@ -235,11 +235,11 @@ struct netfront_accel_hooks accel_hooks 
 
 
 unsigned max_pages = NETFRONT_ACCEL_DEFAULT_BUF_PAGES;
-module_param (max_pages, int, 0666);
+module_param(max_pages, int, 0644);
 MODULE_PARM_DESC(max_pages, "Number of buffer pages to request");
 
 unsigned buffer_split = 2;
-module_param (buffer_split, int, 0666);
+module_param(buffer_split, int, 0644);
 MODULE_PARM_DESC(buffer_split, "Fraction of buffers to use for TX, rest for 
RX");
 
 




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>