Re: [Xen-devel] [PATCH] new hvm platform vhpet enable parameter

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 14/2/08 19:48, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:

>> It enables it by default if the tools do not explicitly
>> instruct either way.... for old saved guest images...
> 
> OK, I see.  I'm glad you caught that.
> 
> But does that mean if a guest config file does not explicitly
> have a "hpet = 0" line, the default will be on?  If so,
> that's different from how I intended.  Perhaps the
> code in XendDomainInfo _constructDomain should be modified
> to set it to zero if "hpet is None"?  Else, I'll bet
> guests created by virt-install will end up with hpet on.

Yes, that's possible. Possibly XendConfig.py should set a default. Or
virt-install itself should do so.

> Also it occurs to me it might be a good idea to add a
> gdprintk in hvm.c so that whether the hpet is on or not
> is visibly logged.

There are many config options for an HVM guest, none of which are logged by
Xen. It would be inconsistent to log just this one.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel