Re: [Xen-devel] Bug in Linux dom0 netback?

To:	Joakim Dahlstedt <jda@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] Bug in Linux dom0 netback?
From:	Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date:	Tue, 05 Feb 2008 10:03:41 +0000
Cc:	Jan Beulich <jbeulich@xxxxxxxxxx>
Delivery-date:	Tue, 05 Feb 2008 02:04:14 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<0A0354E688485F4F997AA71F4A3343E4028522F3@xxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	Achn3MtTOyJvbQxKRv2tKmJV3hAL1AAAZb+2
Thread-topic:	[Xen-devel] Bug in Linux dom0 netback?
User-agent:	Microsoft-Entourage/11.3.6.070618

On 5/2/08 09:52, "Joakim Dahlstedt" <jda@xxxxxxx> wrote:

> In Xen 3.1 the code in net_rx_action looked like this:
> if (npo.mcl_prod &&
>    !xen_feature(XENFEAT_auto_translated_physmap))
> 
> It seems like someone wanted to avoid the check in the if-statement and
> turned it into a BUG_ON statement inside the if instead - but forgot to
> invert the condition.
> 
> Can anyone confirm?

Yes, that's a bug. It would only trigger with old domUs which have a
netfront driver that does not have the new 'copying receiver' support. It
was introduced by c/s 393 a couple of weeks ago.

Thanks for tracking it down!

 -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] Bug in Linux dom0 netback?