[Xen-devel] Re: Domain Groups - VMM Support

["Mike D. Day" <ncmike@xxxxxxxxxx>]

On 18/12/07 11:02 -0500, Chris wrote:

> --- xen-unstable/xen/arch/x86/x86_32/entry.S  2007-11-19 10:38:08.000000000 
> -0500
> +++ xen-unstable-trp-domgrps-rebase-tip/xen/arch/x86/x86_32/entry.S   
> 2007-11-19 18:42:00.000000000 -0500
> @@ -682,6 +682,7 @@
>          .long do_sysctl             /* 35 */
>          .long do_domctl
>          .long do_kexec_op
> +        .long do_domgrpctl
>          .rept NR_hypercalls-((.-hypercall_table)/4)
>          .long do_ni_hypercall
>          .endr
> @@ -725,6 +726,7 @@
>          .byte 1 /* do_sysctl            */  /* 35 */
>          .byte 1 /* do_domctl            */
>          .byte 2 /* do_kexec_op          */
> +        .byte 1 /* do_domgrpctl         */
>          .rept NR_hypercalls-(.-hypercall_args_table)


I looked at creating a new hypervisor for scheduling groups, but found
it much simpler to add a new sub-function under the dom_ctl
hypercall. It markedly reduced the size of the patch and I didn't see
any downside. It might make sense to do the same thing here. That way
you wouldn't need to add the new hypercall to every jump table.

> --- xen-unstable/xen/common/domgrp.c  1969-12-31 19:00:00.000000000 -0500
> +++ xen-unstable-trp-domgrps-rebase-tip/xen/common/domgrp.c   2007-11-26 
> 16:46:46.000000000 -0500
> @@ -0,0 +1,315 @@
> +/******************************************************************************
> + * domgrp.c
> + *
> + * Generic domain group-handling functions.
> + *

This is a really good grouping mechanism. To merge with scheduling
groups, it may be nice to have an extensible structure like we do with
schedulers in Xen. The scheduler pattern is a good one to follow, it
separates general scheduling operations from specific
implementations. We could do something like that here. I doubt that
the set of group operations in this patch is the sum total of all
useful group operations on domains so it needs to be simple to add
group operations in the future without breaking any hypercalls and
without disruptive patches.

I think its worth an attempt to merge the scheduling groups with
domain groups. I'll start looking at some of the ideas I mentioned
above, be happy to work with anyone else who wants to have a go.

Mike

-- 
Mike D. Day
IBM LTC
Cell: 919 412-3900
Sametime: ncmike@xxxxxxxxxx AIM: ncmikeday  Yahoo: ultra.runner
PGP key: http://www.ncultra.org/ncmike/pubkey.asc

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel