WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel][RFC][PATCH][ioemu] strip tap:aio from param

To: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel][RFC][PATCH][ioemu] strip tap:aio from param
From: Pat Campbell <plc@xxxxxxxxxx>
Date: Tue, 29 Jan 2008 13:06:37 -0700
Delivery-date: Tue, 29 Jan 2008 12:11:00 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.6 (X11/20070801)
Currently I am not able to mount or boot from an HVM CDROM when it is 
configured for 'tap:aio' instead of 'file'.

disk=[ 'tap:aio:/var/lib/xen/images/sles10-sp2-fv/disk0,hda,w', '
       tap:aio:/home/iso/sles/SLES10.iso,hdc:cdrom,r', ]

With the attached patch I am able to boot from the CDROM and or mount it.

Patch against xen-unstable tip changes 
xenstore.c:xenstore_parse_domain_config() to rewrite param to xenstore without 
the tap:aio prefix.  This allows xenstore_process_event() to read the correct 
image name. 

It might be better to filter out aio in xenstore_process_event() instead of 
changing param in xenstore. Anybody have an opinion on that?

I will submit a real patch once I have some feedback.

Pat

diff -r 1c826ea72a80 tools/ioemu/xenstore.c
--- a/tools/ioemu/xenstore.c    Wed Jan 23 15:42:52 2008 +0000
+++ b/tools/ioemu/xenstore.c    Tue Jan 29 12:42:24 2008 -0700
@@ -182,6 +182,8 @@ void xenstore_parse_domain_config(int do
             if (!offset)
                 continue ;
             memmove(params, offset+1, strlen(offset+1)+1 );
+            if (pasprintf(&buf, "%s/params", bpath) == 0)
+                xs_write(xsh, XBT_NULL, buf, params, strlen(params));
             fprintf(logfile, "Strip off blktap sub-type prefix to %s\n", 
params); 
         }
 
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>