I'm not sure what particular scenario Bastian was intending to fix, but the
patch does appear to make sense. qemu-dm is going to run in the target
system's dom0. So the 'host CPU' type for qemu-dm is related to
XEN_TARGET_ARCH, not XEN_COMPILE_ARCH nor 'uname -m'. This is a bit
confusing because for qemu there are three environments to consider: build,
host and emulated. I do believe that host CPU need not == build CPU.
-- Keir
On 27/1/08 21:38, "Aron Griffis" <aron@xxxxxx> wrote:
> Keir, Bastian,
>
> What is this changeset intended to fix? My cross-compilation seems to
> work fine without it. With it, the cross-compile blows up because the
> custom ld-script doesn't handle a sys-root (i.e. it overrides the
> linker, gross!)
>
> By my reading, this patch overrides the host CPU detection with
> XEN_TARGET_ARCH, but that's incorrect because the host CPU should be
> the machine on which ioemu is being built, right?
>
> Thanks,
> Aron
>
> Xen staging patchbot-unstable wrote: [Tue Jan 22 2008, 09:36:29AM EST]
>> # HG changeset patch
>> # User Keir Fraser <keir.fraser@xxxxxxxxxx>
>> # Date 1201012477 0
>> # Node ID 51a7e508bd01a1a7d083eada58062aa7b08b839b
>> # Parent 5e03f0bc0aa2fbe8535bedca02d6ab6e4b530794
>> ioemu: Use XEN_TARGET_ARCH instead of uname -m.
>>
>> Signed-off-by: Bastian Blank <waldi@xxxxxxxxxx>
>> ---
>> tools/Makefile | 2 +-
>> tools/ioemu/configure | 36 ++++--------------------------------
>> 2 files changed, 5 insertions(+), 33 deletions(-)
>>
>> diff -r 5e03f0bc0aa2 -r 51a7e508bd01 tools/Makefile
>> --- a/tools/Makefile Tue Jan 22 14:31:10 2008 +0000
>> +++ b/tools/Makefile Tue Jan 22 14:34:37 2008 +0000
>> @@ -78,7 +78,7 @@ endif
>> endif
>> ioemu ioemuinstall:
>> [ -f $(IOEMU_DIR)/config-host.mak ] || \
>> - ( cd $(IOEMU_DIR) && sh configure --prefix=/usr \
>> + ( cd $(IOEMU_DIR) && XEN_TARGET_ARCH=$(XEN_TARGET_ARCH) sh configure
>> --prefix=/usr \
>> $(IOEMU_CONFIGURE_CROSS) )
>> $(MAKE) -C $(IOEMU_DIR) $(patsubst ioemu%,%,$@)
>> ioemuclean:
>> diff -r 5e03f0bc0aa2 -r 51a7e508bd01 tools/ioemu/configure
>> --- a/tools/ioemu/configure Tue Jan 22 14:31:10 2008 +0000
>> +++ b/tools/ioemu/configure Tue Jan 22 14:34:37 2008 +0000
>> @@ -29,43 +29,15 @@ make="make"
>> make="make"
>> install="install"
>> strip="strip"
>> -cpu=`uname -m`
>> target_list=""
>> -case "$cpu" in
>> - i386|i486|i586|i686|i86pc|BePC)
>> +case "$XEN_TARGET_ARCH" in
>> + x86_32)
>> cpu="i386"
>> ;;
>> - armv*b)
>> - cpu="armv4b"
>> - ;;
>> - armv*l)
>> - cpu="armv4l"
>> - ;;
>> - alpha)
>> - cpu="alpha"
>> - ;;
>> - "Power Macintosh"|ppc|ppc64)
>> + powerpc)
>> cpu="powerpc"
>> ;;
>> - mips)
>> - cpu="mips"
>> - ;;
>> - s390)
>> - cpu="s390"
>> - ;;
>> - sparc|sun4[muv])
>> - cpu="sparc"
>> - ;;
>> - sparc64)
>> - cpu="sparc64"
>> - ;;
>> - ia64)
>> - cpu="ia64"
>> - ;;
>> - m68k)
>> - cpu="m68k"
>> - ;;
>> - x86_64|amd64)
>> + x86_64)
>> cpu="x86_64"
>> libdir="lib64"
>> ;;
>>
>> _______________________________________________
>> Xen-staging mailing list
>> Xen-staging@xxxxxxxxxxxxxxxxxxx
>> http://lists.xensource.com/xen-staging
>>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home