WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: ioemu: use asprintf instead of PATH_MAX

To: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Re: ioemu: use asprintf instead of PATH_MAX
From: "Mike D. Day" <ncmike@xxxxxxxxxx>
Date: Wed, 23 Jan 2008 15:53:47 -0500
Delivery-date: Wed, 23 Jan 2008 12:54:25 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080123172005.GI5188@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <20080123172005.GI5188@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Reply-to: ncmike@xxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.15+20070412 (2007-04-11)
erOn 23/01/08 17:20 +0000, Samuel Thibault wrote:
> Use asprintf instead of PATH_MAX, which POSIX says to be facultative.
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>

> -        snprintf(qemu_file, sizeof(qemu_file), 
> -                 "/var/lib/xen/qemu-save.%d", domid);
> +        asprintf(&qemu_file, "/var/lib/xen/qemu-save.%d", domid);

Just a question - afaik asprintf is a unix-ism that isn't supported on
windows. Will this cause problems if also pushed to upstream qemu?

Mike
-- 
Mike D. Day
IBM LTC
Cell: 919 412-3900
Sametime: ncmike@xxxxxxxxxx AIM: ncmikeday  Yahoo: ultra.runner
PGP key: http://www.ncultra.org/ncmike/pubkey.asc

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel