On Wed, Jan 23, 2008 at 05:26:14PM +0000, John Levon wrote:
> On Wed, Jan 23, 2008 at 04:35:55PM +0000, Daniel P. Berrange wrote:
>
> > > However, that means we can't use an empty passwd any more, while that
> > > may be quite useful e.g. in testing environments, so that we would need
> > > the following patch:
> >
> > This is handled in XenD.
> >
> > - If a non-empty passwd is found in the guest config, or in the
> > global XenD config,, then qemu has -vnc :1,passwd on its CLI
> > to turn on password auth.
> > - If there is no guest password and no global XenD password,
> > then qemu has -vnc :1 and no password auth is enabled
> > at all.
>
> I'm confused: if there's no config or xend password at all, then the
> domain won't start:
>
> if vncpasswd is None:
> raise VmError('vncpasswd is not setup in vmconfig or '
> 'xend-config.sxp')
Sorry, my bad description - by no xend password, i meant the default
xend-config.sxp which is in fact ''. Frankly this check above is
a waste of time - it should just treat None as ""
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home