WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] about vga_endboot logic

To: 余上 <yusunn@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] about vga_endboot logic
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 21 Jan 2008 11:45:06 +0000
Delivery-date: Mon, 21 Jan 2008 03:45:33 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <298d852f0801190730s7d405230o8e784cda26cca76b@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AchcIxERT4l2CMgWEdyfNQAX8io7RQ==
Thread-topic: [Xen-devel] about vga_endboot logic
User-agent: Microsoft-Entourage/11.3.6.070618
This is already correct in all active branches (3.1, 3.2, 3.3).

 -- Keir

On 19/1/08 15:30, "余上" <yusunn@xxxxxxxxx> wrote:

> Hi all ,
> 
> I think the logic of vga_endboot is not correct , if I pass vga=keep
> xen will print :
> Xen is keeping VGA console.
> but if I do not pass keep parmeter xen will not print :
> Xen is relinquishing VGA console.
> 
> The new logic should be:
> 
> void vga_endboot(void)
> {
>     if ( !vgacon_enabled )
>         return;
> 
>     printk("Xen is %s VGA console.\n",
>            vgacon_keep ? "keeping" : "relinquishing");
> 
>     if ( !vgacon_keep )
>         vgacon_enabled = 0;
> 
> }
> just move printk before the second if statement
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>