WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: linux c/s 391

To: Jan Beulich <jbeulich@xxxxxxxxxx>, <steven.smith@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: linux c/s 391
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 21 Jan 2008 11:13:39 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 21 Jan 2008 03:14:28 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <47947B19.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AchcHqxT6yC27cgREdyfNQAX8io7RQ==
Thread-topic: linux c/s 391
User-agent: Microsoft-Entourage/11.3.6.070618
On 21/1/08 09:59, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> The comment in the first hunk of that patch contradicts the added code:
> mdelay() is a busy wait loop, i.e. CPU consumption is getting worse. Is it
> possible that msleep() or msleep_interruptible() was meant to be used
> here?

Yes.

> Additionally, since blktap was derived from blkback, shouldn't a similar
> change bo done there?


 Yes.

 -- Keir

> Jan
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>