WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] 3.1.3 (and ??) timer_mode fix in xend for virt-i

To: "Daniel P. Berrange" <berrange@xxxxxxxxxx>, "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] 3.1.3 (and ??) timer_mode fix in xend for virt-install
From: "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx>
Date: Fri, 18 Jan 2008 15:39:55 -0700
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 18 Jan 2008 14:42:00 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080118222050.GF25808@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Oracle Corporation
Reply-to: "dan.magenheimer@xxxxxxxxxx" <dan.magenheimer@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AchaIwqXWjYgjjeJTVi7D+2mfMmivQ==
> So either we need to make sure that 'platform' gets a default value
> set for 'timer_mode', or make the hvm_set_param() call conditional
> like
> 
>    if self.info["platform"].get("timer_mode") is not None:
>        xc.hvm_set_param(self.domid, HVM_PARAM_TIMER_MODE,
>                   long(self.info["platform"].get("timer_mode")))
> 
> I assume the Hypervisor itself already has a default timemode value,
> so making this set_param conditional is probably easiest.

Yes, this is much nicer.

Thanks,
Dan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel