 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] do_callback_op()'s second argument can be const
| To: | Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] do_callback_op()'s second argument can be const |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Fri, 18 Jan 2008 15:44:08 +0000 |
| Delivery-date: | Fri, 18 Jan 2008 07:45:03 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <C3B67211.1B073%Keir.Fraser@xxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AchZ5F0im9AxbsXXEdyBqQAX8io7RQABJkys |
| Thread-topic: | [Xen-devel] [PATCH] do_callback_op()'s second argument can be const |
| User-agent: | Microsoft-Entourage/11.3.6.070618 |
On 18/1/08 15:11, "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx> wrote: >>> I certainly don't see how the chunk below fixes >>> anything -- doesn't it take two lines to state what took one line before? >> >> It fixes the build in the context of the other changes. > > What's the difference between assigning from a variable that is void* and > assigning from a variable that you have cast to void*? Is this just to get > round some stupid compiler warning that shouldn't happen in the first place? > That's why I hate type attributes: const, volatile, and the rest. Stupid > waste of time. I removed the chunk and I can't get the build to fail on i386 or x86_64 with gcc 3.4 or gcc 4.1. Perhaps you build with more anal gcc warning settings? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH] do_callback_op()'s second argument can beconst, Jan Beulich |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] linux: prevent non-Xen modules fromloading in Xen kernel, Jan Beulich |
| Previous by Thread: | Re: [Xen-devel] [PATCH] do_callback_op()'s second argument can beconst, Jan Beulich |
| Next by Thread: | Re: [Xen-devel] [PATCH] do_callback_op()'s second argument can be const, Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
