WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] linux: {start, stop}_hz_timer() not really affecting per

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] linux: {start, stop}_hz_timer() not really affecting periodic timer?
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Wed, 16 Jan 2008 17:17:38 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 16 Jan 2008 09:17:37 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C3B3E562.1AEAE%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <478E4095.76E4.0078.0@xxxxxxxxxx> <C3B3E562.1AEAE%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> 16.01.08 17:46 >>>
>On 16/1/08 16:36, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
>
>>> If the time is in the past then the singleshot timer will fire immediately.
>>> So you'll take a slower path than necessary, but the code as-is will work
>>> fine.
>> 
>> Immediately would mean to me that it would fire on the return path
>> from VCPUOP_set_singleshot_timer, so HYPERVISOR_block() would
>> not (necessarily) find any pending events and hence block when it
>> shouldn't. Or am I missing some magic by which this is being avoided?
>
>The function should only be called with interrupts disabled.

That goes back to what I stated first - there's nothing really requiring
this, it just happens to be that way at present.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel