 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH]Fixes for overflowed calculation in vHPET
| To: | "Shan, Haitao" <haitao.shan@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH]Fixes for overflowed calculation in vHPET |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Tue, 08 Jan 2008 14:14:49 +0000 |
| Cc: | Mark McLoughlin <markmc@xxxxxxxxxx>, "Cui, Dexuan" <dexuan.cui@xxxxxxxxx> |
| Delivery-date: | Tue, 08 Jan 2008 06:17:18 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <823A93EED437D048963A3697DB0E35DE0101FFF6@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AchIXkjedwVeiEy4RPSClG5JXO2lGgAACgGgAYh9u4AA4BsLZg== |
| Thread-topic: | [Xen-devel] [PATCH]Fixes for overflowed calculation in vHPET |
| User-agent: | Microsoft-Entourage/11.3.6.070618 |
On 4/1/08 03:21, "Shan, Haitao" <haitao.shan@xxxxxxxxx> wrote:This patch will fix the bugs in hpet_set_timer. Currently in hpet_tick_to_ns, the approach is multiplying first, which easily causes overflow when tick is quite large. The patch cannot handle arbitrate large ticks duo to the precision requirement and 64bit's value range. But by optimize the equation, a larger ticks than current code can be supported. Also an overflow check is added before the calculation. What’s wrong with the handling of the wrap-around case? It looks okay to me. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] Question about machine time delay in guest domains (Full virtualization), christie kumiko goto |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] Add a timer mode that disables pending missed ticks, Keir Fraser |
| Previous by Thread: | [Xen-devel] [PATCH]Fixes for overflowed calculation in vHPET, Shan, Haitao |
| Next by Thread: | RE: [Xen-devel] [PATCH]Fixes for overflowed calculation in vHPET, Shan, Haitao |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
