Hello,
>> Pausing/resuming cpus looks like arch generic. >> Could you move them to the common code?
Yes. Moved to common/gdbstub.c.
>> TRAP_int3 is x86 specific. >> Please define a constant like TRAP_gdbstab in the arch header and use it.
The value of the vector is not used, yet. I just removed this change from the patch.
>> Adding gdb_arch_write_reg() breaks other arch (IA64 and power). >> How about adding the default definition which just returns >> as a weak symbol?
>>> Just add the no-op implementation to arch/{ia64,powerpc}/gdbstub.c.
I added the no-op implementations to ia64 and powerpc.
Dan.
On Dec 20, 2007 1:39 AM, Keir Fraser < Keir.Fraser@xxxxxxxxxxxx> wrote:
On 20/12/07 01:36, "Isaku Yamahata" < yamahata@xxxxxxxxxxxxx> wrote: > Adding gdb_arch_write_reg() breaks other arch (IA64 and power).
> How about adding the default definition which just returns > as a weak symbol? Just add the no-op implementation to arch/{ia64,powerpc}/gdbstub.c.
-- Keir
gdb_patch
Description: Text document
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|