WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 0/2][PV-on-HVM] Enable Front-end drivers for 2.4

To: Ben Guthro <bguthro@xxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 0/2][PV-on-HVM] Enable Front-end drivers for 2.4 kernels
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Wed, 19 Dec 2007 14:26:28 +0000
Cc: Paul Burkacki <pburkacki@xxxxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 19 Dec 2007 06:27:05 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <47690DE1.7070402@xxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AchCSyRbYtRK7K4+EdyOmwAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH 0/2][PV-on-HVM] Enable Front-end drivers for 2.4 kernels
User-agent: Microsoft-Entourage/11.3.6.070618
I was thinking about solutions other than using ifdefs all over the place. Given that the canonical drivers will soon be the upstream kernel.org versions, we need a solution that doesn’t rely on ifdefs in .c files (since that seems to get rejected upstream). The ‘driver kit’ I was thinking of sounds rather like your own 2.4.*-xen.hg suggestion. Maybe that would be best.

 -- Keir

On 19/12/07 12:26, "Ben Guthro" <bguthro@xxxxxxxxxxxxxxx> wrote:

We tried to minimize the "ifdef mess" as much as possible to be encapulated in as few places as possible.
Which parts in particular concern you? If you could propose some suggestions - we could try another rev.

How would this patch lead to code divergence as submitted?

An ideal solution would be a 2.4.*-xen.hg tree which would support both PV, and PV-on-HVM solutions. However, that was not the goal of these patches.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel