WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Fix xenconsole's "Could not read tty from store"

On Tue, Dec 18, 2007 at 06:47:50PM +0000, Samuel Thibault wrote:

> > openpty() always gives us a slave fd so it's already open.
> 
> Right, but we can avoid using openpty(), but posix_openpt() or
> open("/dev/ptmx"). On linux that works fine.

We could, but that runs the risk of breaking BSD again. Christoph is
away at the moment too. I think keeping the slave open is reasonable and
least chance of hurting us.

> > There's no way on Linux to not busy-loop without keeping a slave fd
> > open, since you set non-blocking on the master fd.
> 
> If the slave fd is not opened at all as suggested above, there should be
> no loop.

I'm not sure we'd always get the right behaviour when it's opened and
then closed again...

Anyway, see my next attempt at a fix :)

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>