WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] Re: [PATCH] Enable Core 2 Duo PerformanceCounters inHVM

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: RE: [Xen-devel] Re: [PATCH] Enable Core 2 Duo PerformanceCounters inHVM guest
From: "Shan, Haitao" <haitao.shan@xxxxxxxxx>
Date: Fri, 14 Dec 2007 23:43:48 +0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Delivery-date: Fri, 14 Dec 2007 07:45:42 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C3880369.19D1A%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <823A93EED437D048963A3697DB0E35DEF7A8E9@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C3880369.19D1A%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acg73Y05/4ppWsehQP2zvW5iILuRqwABFPeHAATfHyAABFZkiwCG+UmAAAJGdv8AADdksAACsmlsAAv7nyA=
Thread-topic: [Xen-devel] Re: [PATCH] Enable Core 2 Duo PerformanceCounters inHVM guest

Hi, Keir,

 

I have carefully checked my coding style according to your comments.

For those which contained hard TABs originally, I only updated what was touched by my patch.

Do you have any comments?

 

Thanks!

 

Haitao Shan

 


From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Keir Fraser
Sent: 2007
1214 17:55
To: Shan, Haitao
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx; Jiang, Yunhong
Subject: Re: [Xen-devel] Re: [PATCH] Enable Core 2 Duo PerformanceCounters inHVM guest

 

1. Shouldn’t the family-specific file be called vpmu_core2.c then?

2. Ah yes, actually setup_irq()/request_irq() is not a suitable interface. The current code is fine.

 -- Keir

On 14/12/07 09:32, "Shan, Haitao" <haitao.shan@xxxxxxxxx> wrote:

Is the virtualisation for Core, or Core 2, or both?
Only Core 2. The reason is that Core do not have global control MSR. This MSR is the only one which will use VMX's HW capability to save and load on vmentry/vmexit. The benefit is the all the other MSRs can be handled with software flexibility, like the "lazy load" mechanism.

I don’t think you need to statically allocate a PMU_VECTOR. request_irq() yourself a vector when VMX is initialised at boot time. This will avoid touching a bunch of generic files.
But request_irq can not ensure PMU can be assigned with a high vector. High vector will help to handle PMIs in time so that gain accurate performance data.

 

Attachment: pmu.patch
Description: pmu.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel