WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Duplicate __HYPERVISOR_grant_table_op in hvm_hypercall32

To: Paul Samon <paul.samon@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Duplicate __HYPERVISOR_grant_table_op in hvm_hypercall32_table?
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Thu, 13 Dec 2007 11:04:49 +0000
Delivery-date: Thu, 13 Dec 2007 02:58:33 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <34cec8c90712130223m5c47652fi18fd068c37162da9@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acg9d/pPOKKMlalrEdy4+wAWy6hiGQ==
Thread-topic: [Xen-devel] Duplicate __HYPERVISOR_grant_table_op in hvm_hypercall32_table?
User-agent: Microsoft-Entourage/11.3.6.070618
The assignment of do_grant_table_op() is bogus. I’ll remove it.

 Thanks,
 Keir


On 13/12/07 10:23, "Paul Samon" <paul.samon@xxxxxxxxx> wrote:

In xen/arch/x86/hvm/hvm.c:
#define HYPERCALL(x)                                        \
    [ __HYPERVISOR_ ## x ] = (hvm_hypercall_t *) do_ ## x
 
#if defined(__i386__)
 
static hvm_hypercall_t *hvm_hypercall32_table[NR_hypercalls] = {
    HYPERCALL(memory_op),
    [ __HYPERVISOR_grant_table_op ] = (hvm_hypercall_t *)hvm_grant_table_op,
    HYPERCALL(xen_version),
    HYPERCALL(grant_table_op),
    HYPERCALL(event_channel_op),
    HYPERCALL(sched_op),
    HYPERCALL(hvm_op)
};
 
#else /* defined(__x86_64__) */
-------------------
For the index __HYPERVISOR_grant_table_op, there are 2 assignments -- do_grant_table_op(), and hvm_grant_table_op() here???
What's the purpose by doing so?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>