 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] fix gdb debugging of hypervisor
| To: | Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] fix gdb debugging of hypervisor |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Tue, 11 Dec 2007 18:04:15 +0000 |
| Delivery-date: | Tue, 11 Dec 2007 09:58:06 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <18270.52192.288867.395215@xxxxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Acg8ID2Xe99KoqgTEdyXZwAWy6hiGQ== |
| Thread-topic: | [Xen-devel] [PATCH] fix gdb debugging of hypervisor |
| User-agent: | Microsoft-Entourage/11.3.6.070618 |
On 11/12/07 17:41, "Ian Jackson" <Ian.Jackson@xxxxxxxxxxxxx> wrote: > The best way to deal with this seemed to me to make > __spurious_page_fault always return false when the debugger is > attached (ie, when we are running the debugging stub). The comments > surrounding __spurious_page_fault seem to suggest that these only > occur when page tables are changed. If that's true then this change > is correct since the debugging stubs don't change page tables. I think it's more obvious to check for in_irq(). That predicate already exists, and pagetables are never updated in IRQ context. And it's exactly the case that __spurious_page_fault() cannot handle. Apart from that the patch is good. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [PATCH] fix gdb debugging of hypervisor, Ian Jackson |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] fix gdb debugging of hypervisor, Ian Jackson |
| Previous by Thread: | [Xen-devel] [PATCH] fix gdb debugging of hypervisor, Ian Jackson |
| Next by Thread: | Re: [Xen-devel] [PATCH] fix gdb debugging of hypervisor, Ian Jackson |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
