On Sat, Dec 08, 2007 at 01:46:57AM +0000, John Levon wrote:
> On Fri, Dec 07, 2007 at 04:30:09PM -0800, Xen patchbot-unstable wrote:
>
> > tools: Rationalise library soname versions.
> >
> > * Arrange for the sonames of libxenstore, libxc, libfsimage and
> > libblktap to be set from a single place in Config.mk.
>
> Grumble... I don't like this at all. You just bumped libfsimage for no
> reason. Can we please fix libfsimage back to the correct versioning?
> (that is 1.0.0)
Likewise xenstore has just been bumped for no reason. The total diff
of the public xenstore head between current 3.1.x releases and unstable
is just
$ diff -u xen-3.1.0-testing.hg/tools/xenstore/xs.h
xen-unstable.hg/tools/xenstore/xs.h
--- xen-3.1.0-testing.hg/tools/xenstore/xs.h 2007-04-23 19:19:32.000000000
-0400
+++ xen-unstable.hg/tools/xenstore/xs.h 2007-10-01 12:03:55.000000000 -0400
@@ -112,7 +112,6 @@
/* Start a transaction: changes by others will not be seen during this
* transaction, and changes will not be visible to others until end.
- * You can only have one transaction at any time.
* Returns NULL on failure.
*/
xs_transaction_t xs_transaction_start(struct xs_handle *h);
This is not ABI incompatible and thus libxenstore should *not* have its
soname changed.
IMHO, the entire rationale of setting all the sonames in one place is just
plain wrong. Libraries evolve independantly and thus their sonames change
independantly. Tieing sonames to the software release version number does
not reflect the reality of their ABI evolution. sonames should only be
changed when an existing API changes in a non-backwards compatible manner
so its perfectly normal for an soname to stay the same across multiple
releases if nothing changes, or merely new APIs are added without changing
existing APIs.
Please revert this change and only adjust the soname of libraries which
have actually changed since the previous 3.1.2 release, which AFAICT
is only libxc.
Regards,
Dan
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home