 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH][TOOLS] blktap: factor out linux specific code
| To: | John Levon <levon@xxxxxxxxxxxxxxxxx>, Christoph Egger <Christoph.Egger@xxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH][TOOLS] blktap: factor out linux specific code |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Fri, 07 Dec 2007 00:37:48 +0000 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Thu, 06 Dec 2007 16:32:34 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20071206190020.GB14504@xxxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Acg4aWP4omr2c6RcEdy6EQAWy6hiGQ== |
| Thread-topic: | [Xen-devel] [PATCH][TOOLS] blktap: factor out linux specific code |
| User-agent: | Microsoft-Entourage/11.3.6.070618 |
On 6/12/07 19:00, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote: > On Thu, Dec 06, 2007 at 07:52:32PM +0100, Christoph Egger wrote: > >> - s->fd_end = lseek64(fd, 0, SEEK_END); >> - if (s->fd_end == (off64_t)-1) >> + s->fd_end = lseek(fd, 0, SEEK_END); >> + if (s->fd_end == (off_t)-1) > > Why this change? Seems that it will break for any large file? Nope, we turn on implicit 64-bit-safe file operations by throwing LFS goodness into CFLAGS and LDFLAGS in tools/Rules.mk. There's no need to use the explicit *64 function and typedef names. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] 802.1Q VLAN support, Maximilian Wilhelm |
|---|---|
| Next by Date: | Re: [Xen-devel] Re: [Xen-staging] [linux-2.6.18-xen] xenbus: Remove dead code., Keir Fraser |
| Previous by Thread: | Re: [Xen-devel] [PATCH][TOOLS] blktap: factor out linux specific code, John Levon |
| Next by Thread: | [Xen-devel] Using VT-D to grant a Windows DomU access to a PCI Express graphics card?, David Stone |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
