WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] remove pointless code

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] remove pointless code
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Thu, 06 Dec 2007 15:28:17 +0000
Delivery-date: Thu, 06 Dec 2007 07:28:16 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
I'm not sure whether this code was ever good for anything, but it seems
definitely pointless.

As usual, written against 2.6.24-rc3 and made apply against 2.6.18
without further testing.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

Index: head-2007-11-30/drivers/xen/netback/xenbus.c
===================================================================
--- head-2007-11-30.orig/drivers/xen/netback/xenbus.c   2007-12-06 
14:56:17.000000000 +0100
+++ head-2007-11-30/drivers/xen/netback/xenbus.c        2007-12-05 
14:49:56.000000000 +0100
@@ -172,8 +172,6 @@ static int netback_uevent(struct xenbus_
 
        add_uevent_var(envp, num_envp, &i, buffer, buffer_size, &length,
                       "vif=%s", netif->dev->name);
-
-       envp[i] = NULL;
 
        return 0;
 }
Index: head-2007-11-30/drivers/xen/xenbus/xenbus_probe_backend.c
===================================================================
--- head-2007-11-30.orig/drivers/xen/xenbus/xenbus_probe_backend.c      
2007-12-06 14:56:17.000000000 +0100
+++ head-2007-11-30/drivers/xen/xenbus/xenbus_probe_backend.c   2007-12-05 
14:32:49.000000000 +0100
@@ -155,13 +155,6 @@ static int xenbus_uevent_backend(struct 
 
        add_uevent_var(envp, num_envp, &i, buffer, buffer_size, &length,
                       "XENBUS_BASE_PATH=%s", xenbus_backend.root);
-
-       /* terminate, set to next free slot, shrink available space */
-       envp[i] = NULL;
-       envp = &envp[i];
-       num_envp -= i;
-       buffer = &buffer[length];
-       buffer_size -= length;
 
        if (dev->driver) {
                drv = to_xenbus_driver(dev->driver);




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] remove pointless code, Jan Beulich <=