WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][XEN] construct_dom0: Initialize variable before

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH][XEN] construct_dom0: Initialize variable before use
From: "Christoph Egger" <Christoph.Egger@xxxxxxx>
Date: Thu, 6 Dec 2007 15:53:38 +0100
Delivery-date: Thu, 06 Dec 2007 06:55:25 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C37DAC27.197BA%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C37DAC27.197BA%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.7
Great, thanks! I just can't test the removal of the 166GB RAM limit :-)

Christoph


On Thursday 06 December 2007 14:39:51 Keir Fraser wrote:
> Changeset 16548.
>
>  -- Keir
>
> On 29/11/07 13:02, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:
> > Hi!
> >
> > Attached patch initializes d->arch.physaddr_bitsize properly for a
> > 64bit Dom0/64bit hypervisor.
> > This bug has been found when booting a NetBSD/Xen Dom0 with more
> > than 4GB RAM.
> >
> > Without this fix, d->arch.physaddr_bitsize is 0 in
> > domain_clamp_alloc_bitsize(). This causes all attempts to
> > XENMEM_increase_reservation with bits > 0 to fail. More precisely,
> > __alloc_domheap_pages() returns NULL.
> > This impacts Xen heap allocation in general.
> > Question: How did that work on Linux Dom0?
> >
> > I think, initializing physaddr_bitsize to 64 unconditionally is ok
> > because in construct_dom0() it is overridden with the proper value when
> > you boot 64bit hypervisor with a 32bit Dom0. If the hypervisor is not
> > 64bit, physaddr_bitsize isn't used at all anyway.
> >
> > Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>



-- 
AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [Xen-devel] [PATCH][XEN] construct_dom0: Initialize variable before use, Christoph Egger <=