Re: [Xen-devel] Re: [Xen-staging] [xen-unstable] xsm: Consolidate xsm processing within domain control hypercall.

["George S. Coker, II" <gscoker@xxxxxxxxxxxxxx>]

A couple of things:

- For these modifications to work, updates also have to be made to the dummy
module for XSM_ENABLE=y to compile

- I do not think these modifications are a win.  I would like to see this
changeset reverted for the following reasons:

1) While it may reduce the number of lines of code in the domctl hypercall,
it won't really reduce the overall number of lines of code in the hypervisor
if a module chooses to implement security operations on all of the donctl
operations. 

2) This will also impose on the security modules the responsibility to
acquire and hold locks on hypervisor resources.  It would seem dangerous to
give modules this responsibility.

3) Performance will be impacted because of the additional multiplexing in 1)
and additional resource management in 2).

George

On 12/4/07 3:44 PM, "Alex Williamson" <alex.williamson@xxxxxx> wrote:

> 
> On Tue, 2007-12-04 at 13:06 -0700, Alex Williamson wrote:
>> Does this work right across a PV domain save/restore on x86?  On ia64
>> I end up with "Domain-Unnamed" after I save a PV domain and another
>> after I restore it, then do a shutdown.  Reverting this patch restores
>> correct behavior.  Thanks,
> 
>    This also doesn't look like it builds with XSM_ENABLE=y
> 
> Alex

-- 
George S. Coker, II <gscoker@xxxxxxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel