 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH][XEN] construct_dom0: Initialize variable before
| To: | Christoph Egger <Christoph.Egger@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH][XEN] construct_dom0: Initialize variable before use |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Thu, 29 Nov 2007 13:28:00 +0000 |
| Delivery-date: | Thu, 29 Nov 2007 05:28:54 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <200711291402.14214.Christoph.Egger@xxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Acgyi6kp56G8MZ5+EdyThAAX8io7RQ== |
| Thread-topic: | [Xen-devel] [PATCH][XEN] construct_dom0: Initialize variable before use |
| User-agent: | Microsoft-Entourage/11.3.6.070618 |
On 29/11/07 13:02, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote: > Without this fix, d->arch.physaddr_bitsize is 0 in > domain_clamp_alloc_bitsize(). This causes all attempts to > XENMEM_increase_reservation with bits > 0 to fail. More precisely, > __alloc_domheap_pages() returns NULL. > This impacts Xen heap allocation in general. > Question: How did that work on Linux Dom0? Yes, that's pretty broken. It works for Linux because Linux allocates its lowmem I/o pages (e.g., swiotlb) using the XENMEM_exchange command, and that allocates the new memory anonymously in the first instance. This defeats the bitsize clamp check (which is okay just now because our truncation of the phsyical memory map to 166GB is sufficient to ensure that compat domUs can address all memory). -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [PATCH][XEN] construct_dom0: Initialize variable before use, Christoph Egger |
|---|---|
| Next by Date: | [Xen-devel] [VTD][PATCH] Use bitmap to solve domain-id limitation issue, Han, Weidong |
| Previous by Thread: | [Xen-devel] [PATCH][XEN] construct_dom0: Initialize variable before use, Christoph Egger |
| Next by Thread: | Re: [Xen-devel] [PATCH][XEN] construct_dom0: Initialize variable before use, Christoph Egger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
