WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-ia64-devel] Re: [Xen-devel] [PATCH] Create XEN_DOMCTL_set_opt_featu

To: Alex Williamson <alex.williamson@xxxxxx>
Subject: [Xen-ia64-devel] Re: [Xen-devel] [PATCH] Create XEN_DOMCTL_set_opt_feature
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Wed, 28 Nov 2007 19:00:45 +0000
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 28 Nov 2007 11:01:35 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1196275172.7687.33.camel@lappy>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acgx8PrROX3xLp3kEdyqDgAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] Create XEN_DOMCTL_set_opt_feature
User-agent: Microsoft-Entourage/11.3.6.070618
On 28/11/07 18:39, "Alex Williamson" <alex.williamson@xxxxxx> wrote:

>    You're right, thanks for bringing it to my attention that storing it
> in an hvm_param is simply unnecessary.  If we add the guest_os_type
> config option as per the new patch below, and still add the
> XEN_DOMCTL_set_opt_feature call, everything else can be done in
> architecture code.  I'll make a pyxc binding to an xc_ia64_set_os_type
> that gets passed self.guest_os_type and makes use of set_opt_feature.
> This avoids munging the string into an integer entirely and keeps
> guest_os_type out of Xen.  Does this look more reasonable?  Please also
> apply this and the original XEN_DOMCTL_set_opt_feature patch if so.

Yes, this sounds fine to me.

 -- Keir



_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>