xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] [Mini-OS] Fix stack closures

from [Samuel Thibault]

[Permanent Link][Original]

To:	xen-devel@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-devel] [PATCH] [Mini-OS] Fix stack closures
From:	Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
Date:	Fri, 23 Nov 2007 15:47:16 +0000
Delivery-date:	Fri, 23 Nov 2007 07:47:53 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to:	Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mutt/1.5.12-2006-07-14

So as to make backtracing tools happy, correctly close x86 stacks for
new threads as well as on callback in the x86_32 case since there is no
unwind marker.

Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxx>

diff -r 2e05a6173be0 extras/mini-os/arch/x86/x86_32.S
--- a/extras/mini-os/arch/x86/x86_32.S  Fri Nov 23 11:58:11 2007 +0000
+++ b/extras/mini-os/arch/x86/x86_32.S  Fri Nov 23 15:40:40 2007 +0000
@@ -125,6 +125,7 @@
         cmpl $ecrit,%eax
         jb   critical_region_fixup
 11:     push %esp
+        xorl %ebp,%ebp
         call do_hypervisor_callback
         add  $4,%esp
         movl HYPERVISOR_shared_info,%esi
@@ -280,6 +281,8 @@
 ENTRY(thread_starter)
     popl %eax
     popl %ebx
+    pushl $0
+    xorl %ebp,%ebp
     pushl %eax
     call *%ebx
     call exit_thread 
--- a/extras/mini-os/arch/x86/x86_64.S  Fri Nov 23 11:58:11 2007 +0000
+++ b/extras/mini-os/arch/x86/x86_64.S  Fri Nov 23 15:40:40 2007 +0000
@@ -379,6 +378,8 @@
 ENTRY(thread_starter)
         popq %rdi
         popq %rbx
+        pushq $0
+        xorq %rbp,%rbp
         call *%rbx
         call exit_thread 
         

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] [Mini-OS] Fix stack closures, Samuel Thibault <=

Previous by Date:	[Xen-devel] [PATCH] [Mini-OS] Fix x86 initial stack alignment, Samuel Thibault
Next by Date:	RE: [Xen-devel] [VTD][PATCH] Fix ISA IRQ alias issue, Han, Weidong
Previous by Thread:	[Xen-devel] [PATCH] [Mini-OS] Fix x86 initial stack alignment, Samuel Thibault
Next by Thread:	[Xen-devel] [PATCH] [Mini-OS] Optimize get_current(), Samuel Thibault
Indexes:	[Date] [Thread] [Top] [All Lists]