WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] 15142:78389dbb08bb and domain state

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] 15142:78389dbb08bb and domain state
From: John Levon <levon@xxxxxxxxxxxxxxxxx>
Date: Thu, 22 Nov 2007 16:44:34 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 22 Nov 2007 08:45:22 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C36B59DB.18EE1%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20071122160455.GA4798@xxxxxxxxxxxxxxxxxxxxxxx> <C36B59DB.18EE1%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Thu, Nov 22, 2007 at 04:07:55PM +0000, Keir Fraser wrote:

> >> I have now, and it works for me. My domid gets zapped in cleanupDomain(). 
> >> It
> >> gets called twice from destroyDomain(), once via
> >> XendDomain.instance.remove_domain() and the other as a direct invocation.
> > 
> > I don't see any code to zap domid there. BTW the call from
> > remove_domain() shouldn't happen as the _stateGet will be
> > DOM_STATE_HALTED at that point.
> 
> Looks like xen-unstable c/s 15587 needs backporting to 3.1 branch.

Thanks! It does indeed work.

However, isn't it effectively regressing the bug fixed by
15142:78389dbb08bb, whatever that is? It just moves the clearing of
domid a couple of lines down.

regards,
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel