WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] x86: usercopy assembly constraints

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86: usercopy assembly constraints
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Wed, 14 Nov 2007 07:37:01 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 13 Nov 2007 23:36:35 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C35FB77E.185D0%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4739D8A2.76E4.0078.0@xxxxxxxxxx> <C35FB77E.185D0%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> 13.11.07 21:20 >>>
>On 13/11/07 16:02, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
>
>> Besides only being correct this way, this helps work around a gcc 4.3
>> issue.
>> At the same time, add some white space, re-order the inputs, and remove
>> a bogus cast.
>
>What's the bug? Does some gcc allocate the 4th output parameter into one of
>the other used registers (cx,si,di) if we don't use '=&'?

No, the effect is an 'impossible constraint' error, so there's not much reason
to be afraid I think. But as said, the constraint was wrong.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel