xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] Fix non-portable grep usage

from [john . levon]

[Permanent Link][Original]

To:	xen-devel@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-devel] [PATCH] Fix non-portable grep usage
From:	john.levon@xxxxxxx
Date:	Mon, 12 Nov 2007 14:24:41 -0800
Delivery-date:	Mon, 12 Nov 2007 14:25:20 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

# HG changeset patch
# User john.levon@xxxxxxx
# Date 1194905356 28800
# Node ID 695e38fa5029bafc9ee9fc08dc4fe3cbec5a7489
# Parent  8b787636c4ac1b0e303c86ed489d91a63626a17e
Fix non-portable grep usage

grep -q doesn't exist on the default Solaris grep.

Signed-off-by: John Levon <john.levon@xxxxxxx>

diff --git a/tools/firmware/rombios/32bit/Makefile 
b/tools/firmware/rombios/32bit/Makefile
--- a/tools/firmware/rombios/32bit/Makefile
+++ b/tools/firmware/rombios/32bit/Makefile
@@ -34,7 +34,7 @@ clean:
 $(TARGET): subdirs 32bitbios.o util.o
        $(LD) $(LDFLAGS_DIRECT) -s -r 32bitbios.o $(MODULES) util.o -o 
32bitbios_all.o
        @nm 32bitbios_all.o |                                \
-         grep -E -q '^ +U ' && {                            \
+         egrep '^ +U ' 2>/dev/null && {                     \
            echo "There are undefined symbols in the BIOS:"; \
            nm -u 32bitbios_all.o;                           \
            exit 11;                                         \

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] Fix non-portable grep usage, john . levon <= Re: [Xen-devel] [PATCH] Fix non-portable grep usage, Ian Jackson Re: [Xen-devel] [PATCH] Fix non-portable grep usage, John Levon

Previous by Date:	[Xen-devel] Solaris build fix breaks Solaris, John Levon
Next by Date:	[Xen-devel] Release: VMKNOPPIX for X86/X86_64 with Xen3.1.1, KVM48, UML, QEMU, VirtualBox, Kuniyasu Suzaki
Previous by Thread:	[Xen-devel] Solaris build fix breaks Solaris, John Levon
Next by Thread:	Re: [Xen-devel] [PATCH] Fix non-portable grep usage, Ian Jackson
Indexes:	[Date] [Thread] [Top] [All Lists]