WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Xen-staging] [xen-unstable] xend: Allow for non-existen

To: Keir Fraser <keir@xxxxxxxxxxxxx>, John Levon <john.levon@xxxxxxx>
Subject: [Xen-devel] Re: [Xen-staging] [xen-unstable] xend: Allow for non-existent xen-python-path binary.
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Thu, 08 Nov 2007 09:17:31 -0700
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 08 Nov 2007 08:18:08 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200711081534.lA8FYN7l005628@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: HP OSLO R&D
References: <200711081534.lA8FYN7l005628@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2007-11-08 at 15:34 +0000, Xen staging patchbot-unstable wrote:
> # HG changeset patch
> # User Keir Fraser <keir@xxxxxxxxxxxxx>
> # Date 1194535934 0
> # Node ID 0ebac857649591de0e1b57605b054552afb03297
> # Parent  c0bdfda5183d5e9dca5c9bc7a68a6cf40e3f6c58
> xend: Allow for non-existent xen-python-path binary.
> On Solaris, xen-python-path is unnecessary.

   This completely breaks xend for me:

# xend start
Traceback (most recent call last):
  File "/usr/sbin/xend", line 36, in ?
    xpp = os.path.join(os.path.dirname(sys.argv[0], 'xen-python-path'))
TypeError: dirname() takes exactly 1 argument (2 given)

        Alex

> ---
>  tools/misc/xend |   13 +++++++------
>  1 files changed, 7 insertions(+), 6 deletions(-)
> 
> diff -r c0bdfda5183d -r 0ebac8576495 tools/misc/xend
> --- a/tools/misc/xend Thu Nov 08 14:50:01 2007 +0000
> +++ b/tools/misc/xend Thu Nov 08 15:32:14 2007 +0000
> @@ -33,13 +33,14 @@ import time
>  import time
>  import commands
>  
> -result = commands.getstatusoutput(os.path.join(os.path.dirname(sys.argv[0]),
> -                                               'xen-python-path'))
> -if result[0] != 0:
> -    print >>sys.stderr, result[1]
> -    sys.exit(1)
> +xpp = os.path.join(os.path.dirname(sys.argv[0], 'xen-python-path'))
> +if os.path.exists(xpp):
> +    result = commands.getstatusoutput(xpp)
> +    if result[0] != 0:
> +        print >>sys.stderr, result[1]
> +        sys.exit(1)
>  
> -sys.path.append(result[1])
> +    sys.path.append(result[1])
>  
>  from xen.xend.server import SrvDaemon
>  
> 
> _______________________________________________
> Xen-staging mailing list
> Xen-staging@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-staging
> 
-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel