WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [VTD][PATCH] Correct PCI_EXP_DEVCTL_FLR

To: Guy Zana <guy@xxxxxxxxxxxx>, "Han, Weidong" <weidong.han@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [VTD][PATCH] Correct PCI_EXP_DEVCTL_FLR
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Wed, 07 Nov 2007 09:20:20 +0000
Cc: "Kay, Allen M" <allen.m.kay@xxxxxxxxx>
Delivery-date: Wed, 07 Nov 2007 01:21:09 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <9392A06CB0FDC847B3A530B3DC174E7B03DF83A8@xxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acgg7m20Z59wCg70TdKtHWDP4yG7wAALAocgAAE8wJE=
Thread-topic: [Xen-devel] [VTD][PATCH] Correct PCI_EXP_DEVCTL_FLR
User-agent: Microsoft-Entourage/11.3.6.070618
I've no idea where the value 0x1b came from, but bit 15 is the FLR bit in
the DEVCTL register, according to the PCI Express spec. So the patch looks
good.

 -- Keir

On 7/11/07 08:53, "Guy Zana" <guy@xxxxxxxxxxxx> wrote:

> -#define PCI_EXP_DEVCTL_FLR      (0x1b)
> +#define PCI_EXP_DEVCTL_FLR      (1 << 15)
> 
> Can you please explain what is the difference (in functionality) between these
> values?
> 
> Thanks,
> Guy.
> 
>> -----Original Message-----
>> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>> [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of
>> Han, Weidong
>> Sent: Wednesday, November 07, 2007 5:30 AM
>> To: xen-devel@xxxxxxxxxxxxxxxxxxx
>> Cc: Kay, Allen M
>> Subject: [Xen-devel] [VTD][PATCH] Correct PCI_EXP_DEVCTL_FLR
>> 
>> This patch corrects PCI_EXP_DEVCTL_FLR so that function level
>> reset will be really executed, and also replaces some magic
>> numbers with micro.
>> 
>> Signed-off-by: Anthony Xu <anthony.xu@xxxxxxxxx>
>> Signed-off-by: Weidong Han <weidong.han@xxxxxxxxx>
>> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel