WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 0/2] 32bit gdbserver-xen/libxc to debug 64bit gue

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 0/2] 32bit gdbserver-xen/libxc to debug 64bit guest
From: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
Date: Fri, 02 Nov 2007 16:35:45 -0700
Cc: "Kurt C. Hackel" <kurt.hackel@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 02 Nov 2007 16:39:26 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C3508D2E.FD59%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Oracle Corp
References: <C3508D2E.FD59%Keir.Fraser@xxxxxxxxxxxx>
Reply-to: mukesh.rathor@xxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.5 (X11/20070719)


Keir Fraser wrote:
> On 2/11/07 02:14, "Mukesh Rathor" <mukesh.rathor@xxxxxxxxxx> wrote:
>
>> Please note, to achieve the above, an ifdef had to be added to user.h. This
>> forced it to be copied locally. As a result, files that included this header,
>> had also to be created/copied in the xen-sparse tree from the gdbserver tree
>> to include local user.h.
>
> The sparse tree should be overlaid a normal full gdbserver tree, so user.h
> should be in the same place whether you've modified it or not. So I don;t
> see why you'd need to pull in every file that includes user.h.

You are correct, I fixed it and will resubmit the patch, I guess with
a new email.

> The 32-on-64 compat layer inside Xen already builds 32-bit versions of
> structures when building 64-bit Xen. I think they're under include/compat/
> or something like that. It would make sense to make use of those rather than
> hack up the original headers with explicit compat types.

I noticed that. But I am looking for 64bit struct versions when building 32bit
libxc. I figured coming with similar macros the other way would make the
whole think too complex, so adding explicit compat types made sense.
Besides, we kinda needed a debugger soon :).

>  -- Keir

Thanks for your feedback and your time.

Mukesh Rathor
PS: I'll be offline for a while. I can come up with enhancements in
future, or make further fixes, after I come back early Dec.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel